Change in vdsm[master]: autogen.sh: deprecate --system

knesenko at redhat.com knesenko at redhat.com
Sun Mar 23 15:44:03 UTC 2014


Kiril Nesenko has posted comments on this change.

Change subject: autogen.sh: deprecate --system
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.ovirt.org/#/c/25804/5/autogen.sh
File autogen.sh:

Line 21: 
Line 22: autoreconf -if
Line 23: 
Line 24: prefix=/usr
Line 25: libdir=$prefix/lib
quotes
Line 26: sysconfdir=/etc
Line 27: localstatedir=/var
Line 28: if [ -d /usr/lib64 ]; then
Line 29:     libdir=$prefix/lib64


Line 28: [ -d /usr/lib64 ]
[ -d "/usr/lib64" ] && libdir=""${prefix}/lib64"


Line 25: libdir=$prefix/lib
Line 26: sysconfdir=/etc
Line 27: localstatedir=/var
Line 28: if [ -d /usr/lib64 ]; then
Line 29:     libdir=$prefix/lib64
quotes
Line 30: fi
Line 31: 
Line 32: EXTRA_ARGS="\
Line 33: --prefix=$prefix \


Line 35: --localstatedir=$localstatedir \
Line 36: --libdir=$libdir \
Line 37: "
Line 38: 
Line 39: if test "x$1" = "x--system"; then
if [ "${1}" = "--system" ]; then
Line 40:     echo "Please note: --system is deprecated!"
Line 41:     shift
Line 42: fi
Line 43: 


Line 40:     echo "Please note: --system is deprecated!"
Line 41:     shift
Line 42: fi
Line 43: 
Line 44: if test -z "$*" && test -f config.status; then
if [ -z "${*}" ] && [ -f "config.status" ]; then
Line 45:     ./config.status --recheck
Line 46: else
Line 47:     echo "Running ./configure with $EXTRA_ARGS $@"
Line 48:     ./configure $EXTRA_ARGS "$@"


Line 44: if test -z "$*" && test -f config.status; then
Line 45:     ./config.status --recheck
Line 46: else
Line 47:     echo "Running ./configure with $EXTRA_ARGS $@"
Line 48:     ./configure $EXTRA_ARGS "$@"
${EXTRA_ARGS} "${@}"
Line 49: fi && {
Line 50:     echo
Line 51:     echo "Additional commands:"
Line 52:     echo "type 'make all' to compile vdsm."


-- 
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bf8971339a242aa5475a7efbbf4f40051ef293
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list