Change in vdsm[master]: tools: configurator must persist usermod changes

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 23 13:36:32 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: tools: configurator must persist usermod changes
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.ovirt.org/#/c/25974/4//COMMIT_MSG
Commit Message:

Line 7: tools: configurator must persist usermod changes
Line 8: 
Line 9: vdsm-tool configure --force adds to /etc/group (qemu/kvm) sanlock
Line 10: but doesn't persist the file in ovirt node distro which will
Line 11: affect vdsm start on next reboot. The goal for this patch is persist
> vdsm-tool configure think sanlock is not configured and vdsm do not get sta
it was in %pre. we moved it to configurator to centralized all services' configurations, and with the assumption that sanlock will require more specific configs that can be added there and will be remove with the remove-config command.

with that approach it easier to understand what vdsm does while configuring the system for its use (for admin user), and it doesn't happen automatically during the installation.

not sure it worth it, and i won't reject if you revert this to the old fashion in the %pre section. (its not actual conf changes, and this usermod set only once..so i don't have strong reject about it)
Line 12: the /etc/group in case vdsm-tool is running on ovirt-node.
Line 13: 
Line 14: Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562


http://gerrit.ovirt.org/#/c/25974/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 149:                 ),
Line 150:                 raw=True,
Line 151:             )
Line 152:             if rc != 0:
Line 153:                 raise RuntimeError("Failed to persist sanlock config.")
put afterwards sys.stdout.write(out) and sys.stderr.write(err)
Line 154: 
Line 155:     def isconfigured(self):
Line 156:         """
Line 157:         True if sanlock service is configured, False if sanlock service


-- 
To view, visit http://gerrit.ovirt.org/25974
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4a7dea08bac41ff557aa52826463f2bdf481562
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list