Change in vdsm[master]: pre-start: touch/configure vdsm logs

ybronhei at redhat.com ybronhei at redhat.com
Sun Mar 23 12:09:42 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: pre-start: touch/configure vdsm logs
......................................................................


Patch Set 5: Code-Review-1

""If I recall correctly, doing this in pre-start is too late: the files are created as root by vdsm-tool that is run before the service is started.""

wait here, how can it be? please explain .. which vdsm-tool command reports to vdsm log file ?? this is the bug that should be solved, not hacking it to allow such prints from anywhere

-- 
To view, visit http://gerrit.ovirt.org/25912
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6ca927cb447eeb24195cff6a1174e0f9a7295214
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Ryan Barry <rbarry at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list