Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure

mtayer at redhat.com mtayer at redhat.com
Sun Mar 23 12:03:51 UTC 2014


mooli tayer has posted comments on this change.

Change subject: Initial commit for vdsm-tool testing infrastructure
......................................................................


Patch Set 14:

(1 comment)

http://gerrit.ovirt.org/#/c/25263/14/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:

Line 31: LCONF="${LCONF:=@sysconfdir@/libvirt/libvirtd.conf}"
Line 32: QCONF="${QCONF:=@sysconfdir@/libvirt/qemu.conf}"
Line 33: LDCONF="${LDCONF:=@LIBVIRT_SERVICE_DEFAULT@}"
Line 34: QLCONF="${QLCONF:=@sysconfdir@/libvirt/qemu-sanlock.conf}"
Line 35: 
All of these should be defined only in configurator.py and passed as env variables.

That way when configurator.py replaces this script gradually they are defined in one place and in tests monkey patching can be done.
Line 36: # The PACKAGE_VERSION define is not used here because we do not want to
Line 37: # update the libvirt configure file every time we change vdsm package
Line 38: # version. In fact the configure generated here is almost unrelated to the
Line 39: # package version, so anything meaningful can be used here. Since a hard


-- 
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list