Change in vdsm[ovirt-3.4]: libvirt_configure: persist cmd qemu-sanlock.conf

dougsland at redhat.com dougsland at redhat.com
Sun Mar 23 04:35:03 UTC 2014


Hello Fabian Deutsch, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/25992

to review the following change.

Change subject: libvirt_configure: persist cmd qemu-sanlock.conf
......................................................................

libvirt_configure: persist cmd qemu-sanlock.conf

On a ovirt-node if executing vdsm-tool configure --force
with libvirt sanlock enabled it will set /etc/libvirt/qemu-sanlock.conf
but won't use persist command so next reboot the changes will be lost
and vdsm-tool will complain about libvirt not configured during vdsm start.

Change-Id: I299f5cb7af4d2e09208835aeda28ec1f3c3def7d
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25968
Reviewed-by: Fabian Deutsch <fabiand at fedoraproject.org>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/25992/1

diff --git a/lib/vdsm/tool/libvirt_configure.sh.in b/lib/vdsm/tool/libvirt_configure.sh.in
index eacb37c..f2f7c2c 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -318,7 +318,12 @@
     # persist cmd is ovirt_store_config on ovirt-functions
     if isOvirtNode; then
         . /usr/libexec/ovirt-functions
-        ovirt_store_config "${lconf}" "${qconf}" "${ldconf}" "${llogr}"
+        ovirt_store_config \
+            "${lconf}" \
+            "${ldconf}" \
+            "${llogr}" \
+            "${qconf}" \
+            "${qlconf}"
     fi
 
     echo "Reconfiguration of libvirt is done."


-- 
To view, visit http://gerrit.ovirt.org/25992
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I299f5cb7af4d2e09208835aeda28ec1f3c3def7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>


More information about the vdsm-patches mailing list