Change in vdsm[master]: libvirt_configure: move unpersist up

danken at redhat.com danken at redhat.com
Sat Mar 22 21:28:03 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: libvirt_configure: move unpersist up
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

http://gerrit.ovirt.org/#/c/25990/1/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:

Line 281: 
Line 282:     local lnetwork=/etc/libvirt/qemu/networks/autostart/default.xml
Line 283:     rm -f "${lnetwork}"
Line 284: 
Line 285:     local llogr=/etc/logrotate.d/libvirtd
this bags to be extracted to a configure_libvirt_logrotate() function (in a separate patch).
Line 286:     local stanza=`mktemp`
Line 287:     /bin/cat > "${stanza}" <<EOF
Line 288: ## beginning of configuration section by vdsm
Line 289: /var/log/libvirt/libvirtd.log {


Line 297:     compressext .xz
Line 298: }
Line 299: ## end of configuration section by vdsm
Line 300: EOF
Line 301:     # unpersist cmd is remove_config on ovirt-functions
Please replace this comment with something stating that unpersist must occur before editing the original.
Line 302:     if isOvirtNode; then
Line 303:         . /usr/libexec/ovirt-functions
Line 304:         remove_config "${llogr}"
Line 305:     fi


-- 
To view, visit http://gerrit.ovirt.org/25990
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea6ae62990a414f52225ad690ec9c21060c2a48d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list