Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup

nsoffer at redhat.com nsoffer at redhat.com
Fri Mar 21 19:37:36 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: clientIF: prepareVolumePath payload cleanup
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/24636/6/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 282:             elif (device in ('cdrom', 'floppy') and 'specParams' in drive):
Line 283:                 params = drive['specParams']
Line 284:                 if 'vmPayload' in params:
Line 285:                     volPath = self._prepareVolumePathFromPayload(vmId,
Line 286:                         device, params['vmPayload'])
This works with pep8:

    if 'vmPayload' in params:
        volPath = self._prepareVolumePathFromPayload(
            vmId, device, params['vmPayload'])

But your version is better; we are wasting our time on this pep8 indentation brokenness.
Line 287:                 # next line can be removed in future, when < 3.3 engine
Line 288:                 # is not supported
Line 289:                 elif (params.get('path', '') == '' and
Line 290:                       drive.get('path', '') == ''):


-- 
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list