Change in vdsm[ovirt-3.4]: spec: use Requires %{name}

dougsland at redhat.com dougsland at redhat.com
Fri Mar 21 17:36:53 UTC 2014


Hello Kiril Nesenko, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/25986

to review the following change.

Change subject: spec: use Requires %{name}
......................................................................

spec: use Requires %{name}

We should use macros instead of static names in the spec.
If in the future we decide to use different name for vdsm package
it's a matter to put the new package name in Name session.

Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/24301
Reviewed-by: Kiril Nesenko <knesenko at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm.spec.in
1 file changed, 7 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/25986/1

diff --git a/vdsm.spec.in b/vdsm.spec.in
index 581d294..4347840 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -349,7 +349,7 @@
 
 %package debug-plugin
 Summary:        VDSM Debug Plugin
-Requires:       vdsm
+Requires:       %{name}
 Requires:       %{name}-xmlrpc = %{version}-%{release}
 BuildArch:      noarch
 
@@ -358,7 +358,7 @@
 
 %package tests
 Summary:        VDSM Test Suite
-Requires:       vdsm = %{version}-%{release}
+Requires:       %{name} = %{version}-%{release}
 Requires:       dracut
 Requires:       python-nose
 BuildArch:      noarch
@@ -369,7 +369,7 @@
 %package hook-checkimages
 Summary:        Qcow2 disk image format check hook for VDSM
 BuildArch:      noarch
-Requires:       vdsm
+Requires:       %{name}
 
 %description hook-checkimages
 VDSM hook used to perform consistency check on a qcow2 format disk image
@@ -388,7 +388,7 @@
 %package hook-faqemu
 Summary:        Fake qemu process for VDSM quality assurance
 BuildArch:      noarch
-Requires:       vdsm
+Requires:       %{name}
 
 %description hook-faqemu
 VDSM hook used for testing VDSM with multiple fake virtual machines without
@@ -416,7 +416,7 @@
 %package hook-extnet
 Summary:        Force a vNIC to connect to a specific libvirt network
 BuildArch:      noarch
-Requires:       vdsm = %{version}-%{release}
+Requires:       %{name} = %{version}-%{release}
 
 %description hook-extnet
 VDSM hook which allows to connect a vNIC to a libvirt network that is managed
@@ -507,7 +507,7 @@
 %package hook-qemucmdline
 Summary:        QEMU cmdline hook for VDSM
 BuildArch:      noarch
-Requires:       vdsm
+Requires:       %{name}
 
 %description hook-qemucmdline
 Provides support for injecting QEMU cmdline via VDSM hook.
@@ -561,7 +561,7 @@
 %package hook-vmfex-dev
 Summary:        VM-FEX vNIC support for VDSM
 BuildArch:      noarch
-Requires:       vdsm = %{version}-%{release}
+Requires:       %{name} = %{version}-%{release}
 Conflicts:      hook-vmfex
 
 %description hook-vmfex-dev


-- 
To view, visit http://gerrit.ovirt.org/25986
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a20093e59990127598d70918b62ab9ea3d5c429
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>


More information about the vdsm-patches mailing list