Change in vdsm[master]: virt: migration: add monitor thread control loop

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Mar 21 12:34:53 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: migration: add monitor thread control loop
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/25976/3/vdsm/migration.py
File vdsm/migration.py:

Line 420: progress_timeout
Please move the configuration out of here and make them attributes

There's no reason for those values to be retrieved/recalculated every second


-- 
To view, visit http://gerrit.ovirt.org/25976
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie422bead060c8ba2bfd4bfada522b91d56697841
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list