Change in vdsm[master]: virt: migration: merge monitor and downtime thread

fromani at redhat.com fromani at redhat.com
Fri Mar 21 12:14:33 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: migration: merge monitor and downtime thread
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

I hate to waste +1s but I need to.

http://gerrit.ovirt.org/#/c/25977/3/vdsm/migration.py
File vdsm/migration.py:

Line 370:         while not self._stop.isSet():
Line 371:             self._stop.wait(1.0)
Line 372:             if self.enabled:
Line 373:                 self.monitor_migration(step)
Line 374:                 self.monitor_downtime(step)
This is a bug. This has to be done even if the monitor is for some reason disabled. Will fix.
Line 375:             step += 1
Line 376: 
Line 377:         self._vm.log.debug('migration monitor thread exiting')
Line 378: 


-- 
To view, visit http://gerrit.ovirt.org/25977
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ac66331b44435a9cffeb9de1454db6843245979
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list