Change in vdsm[master]: virt: migration: use contextmanager for monitor

fromani at redhat.com fromani at redhat.com
Fri Mar 21 12:06:58 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: virt: migration: use contextmanager for monitor
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/25978/3/vdsm/migration.py
File vdsm/migration.py:

Line 256:             self._recover(str(e))
Line 257:             self.log.error("Failed to migrate", exc_info=True)
Line 258: 
Line 259:     @contextmanager
Line 260:     def migrationMonitor(self, startTime):
> We could move this outside of the class (receiving the parameters it needs 
We can and I will, with just the minor caveat that MigrationSourceThread will still need an handle to the MigrationMonitorThread to report the progress. But the move is definitely feasible and I'll do it.
Line 261:         self._monitorThread = MigrationMonitorThread(self._vm,
Line 262:                                                      startTime,
Line 263:                                                      int(self._downtime))
Line 264:         self._monitorThread.start()


-- 
To view, visit http://gerrit.ovirt.org/25978
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7fcd0bedf4f30cc0bcab03339322df1fc5434e8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list