Change in vdsm[master]: Introduction for caching the parsed domain XML
michal.skrivanek at redhat.com
michal.skrivanek at redhat.com
Fri Mar 21 02:35:54 UTC 2014
Michal Skrivanek has posted comments on this change.
Change subject: Introduction for caching the parsed domain XML
......................................................................
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/17694/13/vdsm/vm.py
File vdsm/vm.py:
Line 3105: self._getUnderlyingWatchdogDeviceInfo()
Line 3106: self._getUnderlyingSmartcardDeviceInfo()
Line 3107: self._getUnderlyingConsoleDeviceInfo()
Line 3108: # Obtain info of all unknown devices. Must be last!
Line 3109: self._getUnderlyingUnknownDeviceInfo()
> For another patch: get rid of the "Underlying" in these names.
I tend to like the name. It gives you a clear distinction from vdsm's structures
Line 3110:
Line 3111: def _updateAgentChannels(self):
Line 3112: """
Line 3113: We moved the naming of guest agent channel sockets. To keep backwards
Line 5120: def _getUnderlyingNetworkInterfaceInfo(self):
Line 5121: """
Line 5122: Obtain network interface info from libvirt.
Line 5123: """
Line 5124: # TODO use xpath instead of parseString (here and elsewhere)
This is not valid here anymore, is it?
Line 5125: for x in self._lastXMLDesc.getDeviceElements('interface'):
Line 5126: devType = x.getAttribute('type')
Line 5127: mac = x.getElementsByTagName('mac')[0].getAttribute('address')
Line 5128: alias = x.getElementsByTagName('alias')[0].getAttribute('name')
--
To view, visit http://gerrit.ovirt.org/17694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e106b2f2d3f4160d4e882f1a2880cb1b52fbb22
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list