Change in vdsm[master]: setupNetworks: Fix incorrect mtu overriding when adding mult...

asegurap at redhat.com asegurap at redhat.com
Wed Mar 19 08:16:59 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: setupNetworks: Fix incorrect mtu overriding when adding multiple networks
......................................................................


Patch Set 2: Verified+1

Verified with help of the debugger.

When running the test added in this patch, i.e., testLowerMtuDoesNotOverride
with the debugger, previous to this patch, if a network with lower mtu is
configured after one with higher mtu and the bond is deemed to be in need of
reconfiguring (which I simulate for verification by executing 'ip link set dev
bond0 down') the Bond entity has the lower mtu and the override happens.

After this patch, each addNetwork is run with updated netinfo device
information. As a result, objectivizeNetwork will have the bridge and the vlan
entities with the lower mtu, but the bond will use the maximum mtu between
the current and the one to configure, avoiding the bug. (This was tested as
well with the 'ip link set dev bond0 down')

-- 
To view, visit http://gerrit.ovirt.org/25343
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia375c2e0e4a1896ab99d734e3203a5ef49570f36
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list