Change in vdsm[master]: sp: fix spm start when failing to produce domain

laravot at redhat.com laravot at redhat.com
Wed Mar 19 07:45:00 UTC 2014


Liron Ar has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
> I do not understand how the suggested code is any different from dropping _
Dan,
skipping setDomainRegularRole() on iso and export domains isn't good enough as solution - as the bug will still occur for unreachable data domains - so that's not a bug solver and this could be easily reproduced preventing spm starts.

IMO there's no reason for doing the best effort for having the correct MD here - it may help users and provide better accuracy of the role of each domain (for example, when accessing the storage directly it may help a user to tell in which domain it should look for his most updated OVF files (located under the master), so that's the way i'd prefer it rather than dropping it completely.
Line 214:                                sdUUID, exc_info=True)
Line 215: 
Line 216:     @unsecured
Line 217:     def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list