Change in vdsm[master]: sp: fix spm start when failing to produce domain

danken at redhat.com danken at redhat.com
Tue Mar 18 22:39:39 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
> Up until now we always used best-effort to set the domains role to regular.
Federico, I am afraid I disagree. If we can live with with two domains with ROLES=MASTER, we should not bother to fix this condition. And if we cannot live with that condition, we must not swallow this failure.

I understand that avoiding this "best effort" attempt may expose more bugs that ovirt-3.4 can handle right now, but this patch is destined to *master* branch, which should not include this kind of shortcuts.

Based on the cited BZ, it might be possible to work around the issue by skipping setDomainRegularRole() on iso and export domains. But dropping _updateDomainsRole() seems nicer.
Line 214:                                sdUUID, exc_info=True)
Line 215: 
Line 216:     @unsecured
Line 217:     def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list