Change in vdsm[master]: sp: fix spm start when failing to produce domain

Federico Simoncelli fsimonce at redhat.com
Tue Mar 18 21:47:58 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: sp: fix spm start when failing to produce domain
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/25424/2/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 209: 
Line 210:                 self._backend.setDomainRegularRole(domain)
Line 211:             except Exception:
Line 212:                 # log any exception, but keep going
Line 213:                 self.log.error("Error trying to check/update domain %s role",
> If it's fine to keep the master role on active  domains, why do we even try
Up until now we always used best-effort to set the domains role to regular. Think of a master domain that gets unreachable, we obviously can't set the regular role in its metadata. We'll keep failing to set its role until it gets reachable again but in the end we'll eventually fix it.
So by the rules we're playing now it's not fine to keep the master role on multiple active domains, we just can't fix it on unreachable domains.

That said, this will become irrelevant as soon as we get rid of the master domain.
Line 214:                                sdUUID, exc_info=True)
Line 215: 
Line 216:     @unsecured
Line 217:     def startSpm(self, prevID, prevLVER, maxHostID, expectedDomVersion=None):


-- 
To view, visit http://gerrit.ovirt.org/25424
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f34360770ca8c8741a50956d0cab92bcd9a810
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list