Change in vdsm[master]: vm: report exit reason for migration failed

fromani at redhat.com fromani at redhat.com
Tue Mar 18 16:10:09 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: report exit reason for migration failed
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25164/1/vdsm/vm.py
File vdsm/vm.py:

Line 3764:                         if state[1] == libvirt.VIR_DOMAIN_PAUSED_MIGRATION:
Line 3765:                             exc = MigrationError("Migration Error - Timed out "
Line 3766:                                                  "(did not receive success "
Line 3767:                                                  "event)")
Line 3768:                             exc.vm_exit_reason = vmexitreason.MIGRATION_FAILED
> Dynamic typing is fun, but let's keep static as long as we can - please add
I see your point. I assume then you are not very happy also with the addition at line 3783 below.
If that's the case, I'll take a different route and just use (an enhanced version of, like you suggested) MigrationError.
Line 3769:                             raise exc
Line 3770:                     self.log.debug("NOTE: incomingMigrationFinished event has "
Line 3771:                                    "not been set and wait timed out after %d "
Line 3772:                                    "seconds. Current VM state: %d, reason %d. "


-- 
To view, visit http://gerrit.ovirt.org/25164
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6cb810138e751f8fde784c5f6e0fdaf0f51fa2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list