Change in vdsm[master]: vnic QoS: Fix specParams to XML definition conversion

asegurap at redhat.com asegurap at redhat.com
Tue Mar 18 10:22:38 UTC 2014


Antoni Segura Puimedon has posted comments on this change.

Change subject: vnic QoS: Fix specParams to XML definition conversion
......................................................................


Patch Set 1: Verified+1

Passed the improved unit tests and verified with an engine doing:

Creating a Qos class with inbound and outbound values:
booo
In                Out
- avg: 10 Mb      - avg: 20 Mb
- peak: 10 Mb     - peak: 30 Mb
- burst: 100 Mb   - burst: 100 Mb


foo
In                Out
- avg: Unlimited      - avg: 5 Mb
- peak: Unlimited     - peak: 10 Mb
- burst: Unlimited    - burst: 50 Mb

Then created a vNic profile booo and a vNic profile foo. I created a VM with
a vNic using boo and checked that libvirt dumpxml reports the bandwidth:
    <interface type='bridge'>
      <mac address='00:01:a4:ac:87:01'/>
      <source bridge='ovirtmgmt'/>
      <target dev='vnet0'/>
      <model type='virtio'/>
      <filterref filter='vdsm-no-mac-spoofing'/>
      <link state='up'/>
      <bandwidth>
        <inbound average='1280' peak='1280' burst='102400'/>
        <outbound average='2560' peak='3840' burst='102400'/>
      </bandwidth>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </interface>

Then went to edit the vNic to use the 'foo' vNic profile and checked that only
the Out had been modified (reuse old settings):
    <interface type='bridge'>
      <mac address='00:01:a4:ac:87:01'/>
      <source bridge='ovirtmgmt'/>
      <target dev='vnet0'/>
      <model type='virtio'/>
      <filterref filter='vdsm-no-mac-spoofing'/>
      <link state='up'/>
      <bandwidth>
        <inbound average='1280' peak='1280' burst='102400'/>
        <outbound average='640' peak='1280' burst='51200'/>
      </bandwidth>
      <alias name='net0'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/>
    </interface>

As you can see, only the outbound part changed :-) V+1 !

-- 
To view, visit http://gerrit.ovirt.org/25788
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25041b8f853c870388ecd9c9f9176bd384242234
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list