Change in vdsm[master]: autogen.sh: deprecate --system

ybronhei at redhat.com ybronhei at redhat.com
Tue Mar 18 07:32:40 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: autogen.sh: deprecate --system
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

in that case maybe we need to have --local flag for local install if required. some might use it .. need to check if vdsm supports local install at all. i'd wait for dan's response on that one, if it does redundant and we can remove this option

http://gerrit.ovirt.org/#/c/25804/4/autogen.sh
File autogen.sh:

Line 43: 
Line 44: if test -z "$*" && test -f config.status; then
Line 45:     ./config.status --recheck
Line 46: else
Line 47:     echo "Running ./configure with $EXTRA_ARGS $@"
you don't need this echo, you'll see the exact command it runs in the console anyway
Line 48:     ./configure $EXTRA_ARGS "$@"
Line 49: fi
Line 50: 
Line 51: echo


Line 49: fi
the && was here to prevent those prints if the scope above returns false, which is possible if configure fails . i'd keep it


Line 49: fi
Line 50: 
Line 51: echo
Line 52: echo "Additional commands:"
Line 53: echo "type 'make' to compile vdsm."
change to 'make all'. other it "compiles" only part


-- 
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bf8971339a242aa5475a7efbbf4f40051ef293
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list