Change in vdsm[master]: autogen.sh: deprecate --system

dougsland at redhat.com dougsland at redhat.com
Mon Mar 17 19:52:45 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: autogen.sh: deprecate --system
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25804/1/autogen.sh
File autogen.sh:

Line 37: if test -z "$*" && test -f config.status; then
Line 38:     ./config.status --recheck
Line 39: else
Line 40:     EXTRA_ARGS="--prefix=$prefix --sysconfdir=$sysconfdir --localstatedir=$localstatedir --libdir=$libdir"
Line 41:     echo "Running ./configure with $EXTRA_ARGS $@"
> EXTRA_ARGS should be default and moved to line 35 ?
I have moved to line 6 which is better IMO. On line 35 won't affect configure. Thanks for review!
Line 42:     ./configure $EXTRA_ARGS "$@"
Line 43: fi
Line 44: 
Line 45: echo


-- 
To view, visit http://gerrit.ovirt.org/25804
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I74bf8971339a242aa5475a7efbbf4f40051ef293
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list