Change in vdsm[master]: Initial commit for vdsm-tool testing infrastructure
asegurap at redhat.com
asegurap at redhat.com
Mon Mar 17 11:00:53 UTC 2014
Antoni Segura Puimedon has posted comments on this change.
Change subject: Initial commit for vdsm-tool testing infrastructure
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/25263/9/lib/vdsm/tool/tests.py
File lib/vdsm/tool/tests.py:
Line 117: self._setConfig('QCONF', 'qemu')
Line 118: self._setConfig('LDCONF', 'qemu-sanlock')
Line 119:
Line 120: # helpers
Line 121: def _setConfig(self, file, type):
I would recommend this class file writing to use a temporary directory.
setUp(self) would do self._test_dir = tempfile.mkdtemp()
the paths in test_conf_files would use this self._test_dir
tearDown(self) would do shutil.rmtree(self._test_dir)
Line 122: with open(test_conf_files[file], 'w') as f:
Line 123: f.write(sample_config[type])
Line 124:
Line 125: # ssl config validation
--
To view, visit http://gerrit.ovirt.org/25263
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae0fec9b2057c5ba932f38ed5d34d654486043ef
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list