Change in vdsm[master]: Allow getFileStats for non NFS ISO domains

Federico Simoncelli fsimonce at redhat.com
Mon Mar 17 09:45:06 UTC 2014


Federico Simoncelli has posted comments on this change.

Change subject: Allow getFileStats for non NFS ISO domains
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25627/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 2230:         vars.task.setDefaultException(se.GetFileStatsError(sdUUID))
Line 2231:         vars.task.getSharedLock(STORAGE, sdUUID)
Line 2232: 
Line 2233:         dom = sdCache.produce(sdUUID=sdUUID)
Line 2234:         if not dom.isISO:
To avoid the use of this on block domains (impossible) we may want to keep the check using sd.FILE_DOMAIN_TYPES.
Line 2235:             raise se.GetFileStatsError(sdUUID)
Line 2236: 
Line 2237:         fileStats = dom.getFileList(pattern=pattern,
Line 2238:                                     caseSensitive=caseSensitive)


-- 
To view, visit http://gerrit.ovirt.org/25627
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7107d20b1b8b341086800bb35def895a70c4b4f0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list