Change in vdsm[master]: vm: Set numatune and guest numa topology

fromani at redhat.com fromani at redhat.com
Mon Mar 17 08:55:39 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: Set numatune and guest numa topology
......................................................................


Patch Set 2: Code-Review+1

looks OK.
It seems already OK, but please be careful when adding CPU features: make sure PPC64 supports them, or add them only in the X86_64 path.
Once again: at glance it seems already OK but I was bitten by this once and I'd like to point out.

-- 
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list