Change in vdsm[master]: Avoid to recompile namedtuple ATTR classes in lvm.

fromani at redhat.com fromani at redhat.com
Mon Mar 17 08:46:48 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: Avoid to recompile namedtuple ATTR classes in lvm.
......................................................................


Patch Set 2: Code-Review+1

looks OK to me. Benchmark results will follow up ASAP.

I also think it could be merged anyway.
My only (very minor) concern is about the direct access to the _fields -in general I don't like to access private fields- but I don't see yet how to make it better.

-- 
To view, visit http://gerrit.ovirt.org/25678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I66110a7f25fb5cfd80ddffe9a22e1cbac11de447
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim at redhat.com>
Gerrit-Reviewer: Meital Bourvine <mbourvin at redhat.com>
Gerrit-Reviewer: Meital bourvine <meitalbourvine at gmail.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list