Change in vdsm[master]: pep8: use multiline blacklist

danken at redhat.com danken at redhat.com
Sun Mar 16 18:14:09 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: pep8: use multiline blacklist
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25416/2/Makefile.am
File Makefile.am:

Line 71: 	$(PEP8) --version
Line 72: 	for x in $(PEP8_BLACKLIST); do \
Line 73: 	    exclude="$${exclude},$${x}" ; \
Line 74: 	done ; \
Line 75: 	$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
> i didn't think about that... good point for not having the list
/me doesn't understand your comment! If you want me to abandon the patch just say.
Line 76: 	@if test -f .gitignore; then \
Line 77: 	  for i in `git ls-files \*.in`; do \
Line 78: 	    if ! grep -q -x $${i%%.in} .gitignore; then \
Line 79: 	      echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list