Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt

danken at redhat.com danken at redhat.com
Thu Mar 13 16:02:25 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: libvirt_configure: unpersist logrotate.d/libvirt
......................................................................


libvirt_configure: unpersist logrotate.d/libvirt

On commit 247a76e7 we moved the libvirt settings to libvirt_configure.sh.in and now
we see that vdsm cannot rename temp. file to /etc/logrotate.d/libvirtd on
ovirt-node system at the stage we execute vdsm-tool configure --force.
This patch will add the command unpersist before renaming the file,
otherwise ovirt-node will complain with "Device or resource busy".

Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1074257
Signed-off-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/25700
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Douglas Schilling Landgraf: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list