Change in vdsm[master]: iscsi: Use tpgt when login, update or remove iscsi node

dougsland at redhat.com dougsland at redhat.com
Wed Mar 12 23:53:18 UTC 2014


Douglas Schilling Landgraf has posted comments on this change.

Change subject: iscsi: Use tpgt when login, update or remove iscsi node
......................................................................


Patch Set 1: Verified-1

(1 comment)

-1 for pep8 

./vdsm/storage/iscsi.py:148:80: E501 line too long (80 > 79 characters)
./vdsm/storage/iscsi.py:170:80: E501 line too long (80 > 79 characters)

http://gerrit.ovirt.org/#/c/25706/1/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

Line 144: 
Line 145: def addIscsiNode(iface, target, credentials=None):
Line 146:     targetName = target.iqn
Line 147:     portalStr = "%s:%d,%d" % (target.portal.hostname, target.portal.port,
Line 148:                               target.portal.group if target.portal.group else 1)
Hello, What about a constant instead of '1' ?
Line 149:     with _iscsiadmTransactionLock:
Line 150:         iscsiadm.node_new(iface.name, portalStr, targetName)
Line 151:         try:
Line 152:             if credentials is not None:


-- 
To view, visit http://gerrit.ovirt.org/25706
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11a6a556d31524f4fae4786f5735accaf1cefb34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list