Change in vdsm[master]: libvirt_configure: unpersist logrotate.d/libvirt

ybronhei at redhat.com ybronhei at redhat.com
Wed Mar 12 22:22:51 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: libvirt_configure: unpersist logrotate.d/libvirt
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25700/2/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:

Line 305: 
Line 306:     # unpersist cmd is remove_config on ovirt-functions
Line 307:     if isOvirtNode; then
Line 308:         . /usr/libexec/ovirt-functions
Line 309:         remove_config "${llogr}"
> You meant, unpersist? On rhev-h you cannot rename a file without unpersit i
you only remove here the old config, which seems redundant to me
Line 310:     fi
Line 311:     @MV_PATH@ "${stanza}" "${llogr}"
Line 312: 
Line 313:     if [ -n "${oldmod}" ]; then


-- 
To view, visit http://gerrit.ovirt.org/25700
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd0e6b3ea39680ac3fc8ec5731aa6be3bd8e4deb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand at fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list