Change in vdsm[master]: hsm: Distinguish between iface and initiator when creating i...

nsoffer at redhat.com nsoffer at redhat.com
Tue Mar 11 22:24:39 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: hsm: Distinguish between iface and initiator when creating iSCSI iface
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 147:     sd.POSIXFS_DOMAIN: 'posixfs',
Line 148:     sd.GLUSTERFS_DOMAIN: 'glusterfs'}
Line 149: 
Line 150: 
Line 151: def _resolveIscsiIface(ifaceName, initiatorName):
Renaming this function is not related to this fix. Can you split it to separate patch?
Line 152:     if not ifaceName:
Line 153:         return iscsi.IscsiInterface('default')
Line 154: 
Line 155:     for iface in iscsi.iterateIscsiInterfaces():


-- 
To view, visit http://gerrit.ovirt.org/25628
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ea42e63e3e09babaa283c4e97e341ff259a6945
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list