Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

ybronhei at redhat.com ybronhei at redhat.com
Sat Mar 8 08:50:47 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 8:

(2 comments)

thanks! only the files path in constants is annoying me. we use it only in libvirtConfigureModule so hold it there

http://gerrit.ovirt.org/#/c/21772/8/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 42: QEMU_PROCESS_GROUP = '@QEMUGROUP@'
Line 43: 
Line 44: #
Line 45: # SASL definitions
Line 46: #
why changing that? if comment, at least make it informative, like this is being used for libvirt communication
Line 47: SASL_USERNAME = "vdsm at ovirt"
Line 48: 
Line 49: # This is the domain version translation list
Line 50: # DO NOT CHANGE OLD VALUES ONLY APPEND


Line 85: SYSCONF_PATH = '@sysconfdir@'
Line 86: P_SYSTEMCTL_CONF = SYSCONF_PATH + '/sysctl.d/vdsm'
Line 87: P_VDSM_LCONF = SYSCONF_PATH + '/libvirt/libvirtd.conf'
Line 88: P_VDSM_LDCONF = SYSCONF_PATH + '/sysconfig/libvirtd'
Line 89: P_VDSM_QCONF = SYSCONF_PATH + '/libvirt/qemu.conf'
lets move those to configurator.py ? only there we use it.. maybe sysconf_path can stay here
Line 90: 
Line 91: #
Line 92: # External programs (sorted, please keep in order).
Line 93: #


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list