Change in vdsm[ovirt-3.4]: xmlrpc: [Fix] Use correct base class for parsing request

Gustavo Frederico Temple Pedrosa gustavo.pedrosa at eldorado.org.br
Fri Mar 7 20:34:08 UTC 2014


Gustavo Frederico Temple Pedrosa has uploaded a new change for review.

Change subject: xmlrpc: [Fix] Use correct base class for parsing request
......................................................................

xmlrpc: [Fix] Use correct base class for parsing request

Previously we always used SecureXMLRPCServer.parse_request, even when
using SimpleXMLRPCServer. That happened to work since both inherit
parse_request from BaseHTTPServer. This patch use the correct base
class, so if one of them will override parse_request, we use the correct
method.
Note: Without this fix ssl=false does not work on python 2.7

Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1074063
Signed-off-by: Gustavo Pedrosa <gustavo.pedrosa at eldorado.org.br>
Reviewed-on: http://gerrit.ovirt.org/24289
---
M vdsm/BindingXMLRPC.py
1 file changed, 1 insertion(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/25524/5

diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index bafc7c7..d23235b 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -207,8 +207,7 @@
                                    exc_info=True)
 
             def parse_request(self):
-                r = (SecureXMLRPCServer.SecureXMLRPCRequestHandler.
-                     parse_request(self))
+                r = basehandler.parse_request(self)
                 threadLocal.flowID = self.headers.get(HTTP_HEADER_FLOWID)
                 return r
 


-- 
To view, visit http://gerrit.ovirt.org/25524
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef737c02afb97580179f381e0f227ee94e1383f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.4
Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list