Change in vdsm[master]: stats: report detailed VM down status

danken at redhat.com danken at redhat.com
Fri Mar 7 11:12:26 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: stats: report detailed VM down status
......................................................................


stats: report detailed VM down status

When a VM goes down it reports an exitCode and an
exitMessage which is passed verbatim to the VM log.

In order to have translatable messages, a more detailed
exit reason code is needed.
This patch is the first step towards an explicit, detailed
exit reason value. It laids the ground for a full resolution.

A new explicit exit reason code field is introduced in the
response, to be filled with the detailed status code.
The field is added separately for backward
compatibility with the existing interface.

Future work will split the GenericError code into detailed
codes.

Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd
Bug-Url: https://bugzilla.redhat.com/557125
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/22631
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Tested-by: Dan Kenigsberg <danken at redhat.com>
---
M debian/vdsm.install
M tests/vmTests.py
M vdsm.spec.in
M vdsm/Makefile.am
M vdsm/vm.py
A vdsm/vmexitreason.py
M vdsm_api/vdsmapi-schema.json
7 files changed, 146 insertions(+), 17 deletions(-)

Approvals:
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/22631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list