Change in vdsm[master]: stats: report detailed VM down status

danken at redhat.com danken at redhat.com
Thu Mar 6 21:59:08 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: stats: report detailed VM down status
......................................................................


Patch Set 14: Code-Review+2

(1 comment)

http://gerrit.ovirt.org/#/c/22631/14/tests/vmTests.py
File tests/vmTests.py:

Line 654: @contextmanager
Line 655: def FakeVM(params=None):
Line 656:     with namedTemporaryDir() as tmpDir:
Line 657:         with MonkeyPatchScope([(constants, 'P_VDSM_RUN', tmpDir)]):
Line 658:             with MonkeyPatchScope([(libvirtconnection, 'get',
MonkeyPatchScope accepts a *list* of patches to make. Make use of it, and save us an indentation.
Line 659:                                     lambda x: ConnectionMock())]):
Line 660:                 vmParams = {'vmId': 'TESTING'}
Line 661:                 vmParams.update({} if params is None else params)
Line 662:                 yield vm.Vm(None, vmParams)


-- 
To view, visit http://gerrit.ovirt.org/22631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list