Change in vdsm[master]: guest: Add support for guest cpu topology
fromani at redhat.com
fromani at redhat.com
Thu Mar 6 15:07:20 UTC 2014
Francesco Romani has posted comments on this change.
Change subject: guest: Add support for guest cpu topology
......................................................................
Patch Set 15:
(1 comment)
mostly OK just a minor nit
http://gerrit.ovirt.org/#/c/23258/15/vdsm/guestIF.py
File vdsm/guestIF.py:
Line 304: topology = {}
Line 305: for name in API_VALUES:
Line 306: if name in args:
Line 307: topology[name] = args[name]
Line 308: if len(topology) > 0:
I'd just use
if topology:
Line 309: self.guestInfo['cpuTopology'] = topology
Line 310: else:
Line 311: self.log.error('Unknown message type %s', message)
Line 312:
--
To view, visit http://gerrit.ovirt.org/23258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I827ab095ee9270faf27f44e91c7bc998e133351e
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list