Change in vdsm[master]: pep8: use multiline blacklist

danken at redhat.com danken at redhat.com
Wed Mar 5 13:24:11 UTC 2014


Dan Kenigsberg has uploaded a new change for review.

Change subject: pep8: use multiline blacklist
......................................................................

pep8: use multiline blacklist

Yaniv thinks it's nicer that way.

Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M Makefile.am
1 file changed, 9 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/25416/1

diff --git a/Makefile.am b/Makefile.am
index 3f4266c..4c8781f 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -53,7 +53,11 @@
 WITH_HOOKS = --define="with_hooks 1"
 endif
 
-PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
+PEP8_BLACKLIST = config.py \
+	constants.py \
+	crossImportsTests.py \
+	vdsm.py \
+	$(NULL)
 
 SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
 	'lv' from line .*"
@@ -64,7 +68,10 @@
 		grep -w -v $(SKIP_PYFLAKES_ERR) | \
 		while read LINE; do echo "$$LINE"; false; done
 	$(PEP8) --version
-	$(PEP8) --exclude="$(PEP8_BLACKLIST)" --filename '*.py,*.py.in' .
+	for x in $(PEP8_BLACKLIST); do \
+	    exclude="$${exclude},$${x}" ; \
+	done ; \
+	$(PEP8) --exclude=$${exclude} --filename '*.py,*.py.in' .
 	@if test -f .gitignore; then \
 	  for i in `git ls-files \*.in`; do \
 	    if ! grep -q -x $${i%%.in} .gitignore; then \


-- 
To view, visit http://gerrit.ovirt.org/25416
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e9f4d214ae2bf19029265d230078cf5f67d9e15
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list