Change in vdsm[master]: pep8: whitelist everything

ybronhei at redhat.com ybronhei at redhat.com
Wed Mar 5 11:14:14 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: pep8: whitelist everything
......................................................................


Patch Set 1:

(1 comment)

verified means no pep8 complain after that change?

http://gerrit.ovirt.org/#/c/25392/1/Makefile.am
File Makefile.am:

Line 52: if HOOKS
Line 53: WITH_HOOKS = --define="with_hooks 1"
Line 54: endif
Line 55: 
Line 56: PEP8_BLACKLIST = config.py,constants.py,crossImportsTests.py,vdsm.py
is it all the template output files? because we have more
./vdsm_reg/deployUtil.py.in
./vdsm_reg/engine.py.in
./vdsm/dsaversion.py.in
./vdsm/gluster/hostname.py.in
./vdsm/mk_sysprep_floppy.in
./vdsm/dumpStorageTable.py.in
./vds_bootstrap/deployUtil.py.in
./lib/vdsm/tool/validate_ovirt_certs.py.in
./lib/vdsm/tool/load_needed_modules.py.in
./lib/vdsm/vdscli.py.in

what about those?
do we want to check all vdsm subfolders?

can you arrange this list as all lists in the file, one file in a line?
Line 57: 
Line 58: SKIP_PYFLAKES_ERR = "\./vdsm/storage/lvm\.py.*: list comprehension redefines \
Line 59: 	'lv' from line .*"
Line 60: 


-- 
To view, visit http://gerrit.ovirt.org/25392
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I237e19d5cdd087d8fe0f337f41560b72b1c80a37
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list