Change in vdsm[master]: interface xml: add <driver> subelement in an extendible way

danken at redhat.com danken at redhat.com
Wed Mar 5 10:42:43 UTC 2014


Dan Kenigsberg has uploaded a new change for review.

Change subject: interface xml: add <driver> subelement in an extendible way
......................................................................

interface xml: add <driver> subelement in an extendible way

This patch makes no functional change. A <driver> subelement is added to
an <interface> element iff requested by the "vhost" custom property.

Change-Id: I1514fa11734e8d7e71a8c4aa51733d5087c38828
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vm.py
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/25389/1

diff --git a/vdsm/vm.py b/vdsm/vm.py
index af8b3be..549421c 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1354,8 +1354,12 @@
 
     def _customize(self):
         # Customize network device
+        self.driver = {}
+
         vhosts = self._getVHostSettings()
-        self.driver = vhosts.get(self.network, False)
+        if vhosts:
+            self.driver['name'] = vhosts.get(self.network, False)
+
         try:
             self.sndbufParam = self.conf['custom']['sndbuf']
         except KeyError:
@@ -1384,6 +1388,7 @@
             <mac address="aa:bb:dd:dd:aa:bb"/>
             <model type="virtio"/>
             <source bridge="engine"/>
+            [<driver name="vhost/qemu"/>]
             [<filterref filter='filter name'/>]
             [<tune><sndbuf>0</sndbuf></tune>]
             [<link state='up|down'/>]
@@ -1409,7 +1414,7 @@
             iface.appendChildWithArgs('boot', order=self.bootOrder)
 
         if self.driver:
-            iface.appendChildWithArgs('driver', name=self.driver)
+            iface.appendChildWithArgs('driver', **self.driver)
 
         if self.sndbufParam:
             tune = iface.appendChildWithArgs('tune')


-- 
To view, visit http://gerrit.ovirt.org/25389
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1514fa11734e8d7e71a8c4aa51733d5087c38828
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list