Change in vdsm[master]: vm: Set numatune and guest numa topology

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Mar 5 07:34:41 UTC 2014


Vinzenz Feenstra has posted comments on this change.

Change subject: vm: Set numatune and guest numa topology
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Please update vdsm_api/vdsmapi-schema.json if you modify the API

Also I don't like the inconsistency of 'vmNumaTopology' vs 'numaMemory'

http://gerrit.ovirt.org/#/c/25254/1/vdsm/vm.py
File vdsm/vm.py:

Line 1157:  
unnecessary paranthesis


Line 1155:         if 'numaMemory' in self.conf:
Line 1156:             numaMemory = self.conf.get('numaMemory')
Line 1157:             if ('nodeset' in numaMemory.keys()):
Line 1158:                 mode = 'strict'
Line 1159:                 if ('mode' in numaMemory.keys()):
same here

But better would be:
mode = numaMemory.get('mode', 'strict')

Which defaults to strict when mode not present
Line 1160:                     mode = numaMemory['mode']
Line 1161:                 nodeset = numaMemory['nodeset'].replace(';', ',')
Line 1162:                 numatune = XMLElement('numatune')
Line 1163:                 numatune.appendChildWithArgs('memory', mode=mode,


-- 
To view, visit http://gerrit.ovirt.org/25254
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88ec56047809b03449a788ead0b97f9ed876712d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Xiaolei Shi <xiao-lei.shi at hp.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list