Change in vdsm[master]: clientIF: prepareVolumePath payload cleanup
nsoffer at redhat.com
nsoffer at redhat.com
Wed Mar 5 07:11:33 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 297: elif (params.get('path', '') == '' and
Line 298: # line above can be removed in future, when < 3.3 engine
Line 299: # is not supported
Line 300: drive.get('path', '') == ''):
Line 301: volPath = ''
> do we intentionally fall out of the inner condition silently? if so, add
Please add test for this case.
Line 302:
Line 303: elif "path" in drive:
Line 304: volPath = drive['path']
Line 305:
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I058206b7506ddbb5ec087c9ea0963a10ed57affb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list