Change in vdsm[master]: Adding remove/disable verbs to vdsm-tool for admin usages

Alon Bar-Lev alonbl at redhat.com
Tue Mar 4 10:25:15 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Adding remove/disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/21772/4/lib/vdsm/tool/passwd.py
File lib/vdsm/tool/passwd.py:

Line 53:     Remove vdsm password for libvirt connection
Line 54:     """
Line 55:     rc, out, err = utils.execCmd(
Line 56:         (constants.P_EXEC_SASL, '-p', '-a', 'libvirt', '-d', constants.SASL_USERNAME,),
Line 57:         raw=True,
> I saw that raw=False (default) splits output lines, and we don't need that.
well, I tend to use default unless there is a good reason, not the other way around :)
Line 58:     )
Line 59:     if rc != 0:


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list