Change in vdsm[master]: vm: consider 'action' when handling I/O errors
nsoffer at redhat.com
nsoffer at redhat.com
Tue Mar 4 07:26:51 UTC 2014
Nir Soffer has posted comments on this change.
Change subject: vm: consider 'action' when handling I/O errors
......................................................................
Patch Set 4:
(2 comments)
Looks ok except the error for unexpected action, which should be a warning.
http://gerrit.ovirt.org/#/c/25157/4/vdsm/vm.py
File vdsm/vm.py:
Line 4568: """
Line 4569: Called back by IO_ERROR_REASON event
Line 4570:
Line 4571: :param err: one of "eperm", "eio", "enospc" or "eother"
Line 4572: Note the different API from that of Vm._onAbnormalStop
Note for later patch - the note about the different API looks outdated. Isn't this Vm._onAbnormalStop?
Line 4573: """
Line 4574: if action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_PAUSE:
Line 4575: self.log.info('abnormal vm stop device %s error %s',
Line 4576: blockDevAlias, err)
Line 4584: err, blockDevAlias)
Line 4585: else:
Line 4586: # we do not support and do not expect other values
Line 4587: self.log.error('I/O error %s device %s action %i ignored',
Line 4588: err, blockDevAlias, action)
This should be a warning, this is not an error condition.
Line 4589:
Line 4590: def _acpiShutdown(self):
Line 4591: self._dom.shutdownFlags(libvirt.VIR_DOMAIN_SHUTDOWN_ACPI_POWER_BTN)
Line 4592:
--
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Gibson <dgibson at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list