Change in vdsm[master]: vm: consider 'action' when handling I/O errors

dgibson at redhat.com dgibson at redhat.com
Tue Mar 4 00:54:19 UTC 2014


David Gibson has posted comments on this change.

Change subject: vm: consider 'action' when handling I/O errors
......................................................................


Patch Set 4: Code-Review-1

The else clause looks as though it could give a really misleading error if qemu/libvirt ever added an action type other than the current stop/report/ignore.  Better to just print "unexpected error action: <value>" or something, maybe?

-- 
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Gibson <dgibson at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list