Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean

danken at redhat.com danken at redhat.com
Mon Mar 3 22:25:07 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

http://gerrit.ovirt.org/#/c/25170/11/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1710: 
Line 1711:                 if bridged:
Line 1712:                     self.assertEqual(net['cfg']['BOOTPROTO'], 'dhcp')
Line 1713: 
Line 1714:                     bridges = self.vdsm_net.netinfo.bridges
I am so sorry, but this now collides with "bridges" from http://gerrit.ovirt.org/25203. Please rename your local variable.
Line 1715:                     self.assertIn(NETWORK_NAME, bridges)
Line 1716:                     self.assertEqual(bridges[NETWORK_NAME]['cfg']['BOOTPROTO'],
Line 1717:                                      'dhcp')
Line 1718: 


-- 
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list