Change in vdsm[master]: netinfo: reduce netinfo instantiation to be closer to linear

danken at redhat.com danken at redhat.com
Mon Mar 3 18:32:11 UTC 2014


Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo: reduce netinfo instantiation to be closer to linear
......................................................................


netinfo: reduce netinfo instantiation to be closer to linear

During each setupNetworks operation there were several points that
could call for a full NetInfo instantiation. This patch reduces
the amount of points that do so by replacing instantiation with
very fast system polling of:

- ifaceUsers: which will now check link objects and networks only if
  necessary
- vlansForIface: which will just use link objects.

Bug-Url: https://bugzilla.redhat.com/1053114
Change-Id: I424e0ba9a99951432dea0365e12a02b7fb7a5bf7
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/23577
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
M vdsm/netconf/ifcfg.py
M vdsm/netconf/iproute2.py
M vdsm/netmodels.py
4 files changed, 42 insertions(+), 27 deletions(-)

Approvals:
  Antoni Segura Puimedon: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/23577
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I424e0ba9a99951432dea0365e12a02b7fb7a5bf7
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list