Change in vdsm[master]: ifcfg: stop leaving leftover bridges when removing bonded ne...

danken at redhat.com danken at redhat.com
Mon Mar 3 18:24:31 UTC 2014


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: stop leaving leftover bridges when removing bonded networks
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.ovirt.org/#/c/25203/2/vdsm/netconf/ifcfg.py
File vdsm/netconf/ifcfg.py:

Line 732: 
Line 733:         :param entry: entry to update (entry=value)
Line 734:         :type entry: string
Line 735: 
Line 736:         :param value: value to update (entry=value)
Please document that a None value actually means "remove entry".
Line 737:         :type value: string
Line 738: 
Line 739:         Update conffile entry with the given value.
Line 740:         """


-- 
To view, visit http://gerrit.ovirt.org/25203
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3de692c7f089d6a9f404c3a2f6f568c12d8a985d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list