Change in vdsm[master]: vm: consider 'action' when handling I/O errors

fromani at redhat.com fromani at redhat.com
Mon Mar 3 13:42:07 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: vm: consider 'action' when handling I/O errors
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/25157/3/vdsm/vm.py
File vdsm/vm.py:

Line 4578:             self._guestCpuRunning = False
Line 4579:             if err.upper() == 'ENOSPC':
Line 4580:                 if not self.extendDrivesIfNeeded():
Line 4581:                     self.log.info("No VM drives were extended")
Line 4582:         elif action == libvirt.VIR_DOMAIN_EVENT_IO_ERROR_REPORT:
> it seems that with this, the guest cpu is not really stopped. This means th
Agreed. Moreover, the docstring at the beginning of the function already suggest when this callback should be triggered. Better to rename in a different patch or to on this one?
Line 4583:             self.log.info('I/O error %s device %s reported to guest OS',
Line 4584:                           err, blockDevAlias)
Line 4585:         else:
Line 4586:             # we do not support and do not expect other values


-- 
To view, visit http://gerrit.ovirt.org/25157
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9299399c3e5bef7e6e3111aa35e3483827ad57da
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list