Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages

Alon Bar-Lev alonbl at redhat.com
Mon Mar 3 12:55:17 UTC 2014


Alon Bar-Lev has posted comments on this change.

Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/21772/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 139:         except RuntimeError:
Line 140:             return False
Line 141: 
Line 142:     def removeConf(self):
Line 143:         vdsm_ver = '-4.9.10'
> This patch fails due to this line. Where from do I get the current version?
this is the version of the change not the version of vdsm... like signature... the fact that the version of vdsm was used once and became the signature is strange but this what we have.
Line 144:         conf_prefix = '## beginning of configuration section by vdsm' + \
Line 145:                       vdsm_ver
Line 146:         conf_suffix = '## end of configuration section by vdsm' + vdsm_ver
Line 147: 


Line 360:                 c.removeConf()
Line 361:             except:
Line 362:                 failed.append(c.getName)
Line 363:     if failed:
Line 364:         sys.stdout.write(
> Done.
yes, other patch if required fixing.
Line 365:             "Could not remove configuration for modules %s\n" % ','.join(failed),
Line 366:         )
Line 367:         raise RuntimeError("Remove configuration failed")
Line 368: 


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list