Change in vdsm[master]: Adding remove\disable verbs to vdsm-tool for admin usages

ybronhei at redhat.com ybronhei at redhat.com
Mon Mar 3 08:18:53 UTC 2014


Yaniv Bronhaim has posted comments on this change.

Change subject: Adding remove\disable verbs to vdsm-tool for admin usages
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/21772/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2013-11-27 13:23:56 +0200
Line 4: Commit:     Mooli Tayer <mtayer at redhat.com>
Line 5: CommitDate: 2014-03-02 20:10:47 +0200
Line 6: 
Line 7: Adding remove\disable verbs to vdsm-tool for admin usages
> I must comment.... \ -> / :)))
the slash for "or" (afaik) should lean to the opposite side of the language writing direction. in hebrew its /, english \ (from left to right)
Line 8: 
Line 9: The spec will be modified separately to use vdsm-tool instead of hard-coded
Line 10: operations
Line 11: 


http://gerrit.ovirt.org/#/c/21772/3/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/configurator.py:

Line 151:             P_VDSM_LDCONF,
Line 152:         ]:
Line 153:             if os.path.exists(path):
Line 154:                 removeSectionFromFile(path, conf_prefix, conf_suffix)
Line 155:         utils.rmFile(P_SYSTEMCTL_CONF)
> is this one^ related to libvirt?
yes, we need to split and arrange - sysctl conf to SystemctlModuleConfigure, move qemu part to QemuMeduleConfigure. 

but this later. in this phase lets just create the removal part, afterwards we'll arrange to modules (i plan also SelinuxModuleConfigure, VdsmModuleConfigure with flags (like having --ssl option for configure and inc) and more improvement for this tool to avoid such scriptish spec file)
Line 156: 
Line 157: 
Line 158: class SanlockModuleConfigure(_ModuleConfigure):
Line 159: 


-- 
To view, visit http://gerrit.ovirt.org/21772
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f2c031436a6d202f856c24d9c9420c8bfdf6df
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list