Change in vdsm[master]: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean

osvoboda at redhat.com osvoboda at redhat.com
Sun Mar 2 22:19:37 UTC 2014


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: bootproto4 is now 'dhcp'/'none' instead of a boolean
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.ovirt.org/#/c/25170/9/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:

Line 678: 
Line 679:             if dev:
Line 680:                 dev['cfg']['BOOTPROTO'] = netInfo['bootproto4']
Line 681:                 break
Line 682: 
> I share Toni's sentiment: a properly-named helper function is better than h
Indeed, I was thinking about a helper function but somehow decided this code would be temporary. But that does not mean it would not stay around for quite long, so I am for moving the code out.

I would however vote for keeping the whole loop the way it is, while renaming netInfo to netAttrs of course. I find Toni's proposal more complex mostly in terms of readability (maybe if "in chain" was on the second line, it would be easier to understand). Yes, I mean passing the whole dictionary to the helper.
Line 683:     return d
Line 684: 
Line 685: 
Line 686: def isVlanned(dev):


-- 
To view, visit http://gerrit.ovirt.org/25170
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaef31f93da978a5793fceae28763ceafedb8d3b6
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list