Change in vdsm[master]: logging: Stop the fileConfig from disabling existing logs

nsoffer at redhat.com nsoffer at redhat.com
Sun Mar 2 15:36:10 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: logging: Stop the fileConfig from disabling existing logs
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

Title can be nicer.

http://gerrit.ovirt.org/#/c/25185/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2014-02-27 19:58:24 +0200
Line 4: Commit:     Dima Kuznetsov <dkuznets at redhat.com>
Line 5: CommitDate: 2014-03-02 13:52:19 +0200
Line 6: 
Line 7: logging: Stop the fileConfig from disabling existing logs
It would be nice if you refine the title:

    logging: Enable all loggers
Line 8: 
Line 9: Unless disable_existsing_loggers is passed as false, logging checks
Line 10: the pre-existing logs and disables any that are not mentioned in the
Line 11: configuration file, this causes various logs to be not visible.


-- 
To view, visit http://gerrit.ovirt.org/25185
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6cbf7d749cfc2d432624213bfe5beb26055e5a8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list